Clueless-Community / collegeAPI

An API that helps you to fetch colleges and their details.

GNU General Public License v3.0

58 stars 61 forks source link

Create allAgricultureColleges.json #99

Closed Subrata2003 closed 2 years ago

Subrata2003 commented 2 years ago

Added Some Famous Agriculture Colleges

Description

Added Some Famous Agriculture Colleges situated in Indian .

Issue Ticket Number

Fixes #(issue_number)

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[✓ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ✓] I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
[✓ ] I have checked to ensure there aren't other open Pull Requests for the same update/change?
[ ✓] I have performed a self-review of my own code
[ ✓] I have commented my code, particularly in hard-to-understand areas
[✓ ] I have made corresponding changes needed to the documentation

nikhil25803 commented 2 years ago

Hey @Over-Thinker, Agriculture colleges are not listed in NIRF right?👀 What page did you scrap to get this data? Please mention here

Subrata2003 commented 2 years ago

No actually these colleges are not listed in basis of nirf. I got those data from college dunia and also some other pages then i make a list of top ranked colleges and then put those . Here the serial is not in nirf ranked but the serial is also from top ranked college to button rank college you can check 😅.

nikhil25803 commented 2 years ago

Hey @Over-Thinker, then it will be specific to the website only right? So we cannot merge this.

Subrata2003 commented 2 years ago

No actually it's not based only the website I also followed some some list also from nirf rank so pls review once

nikhil25803 commented 2 years ago

Okay @Over-Thinker, please upload the respective python file too. That you used to scrape data.

nikhil25803 commented 2 years ago

The files are still not uploaded yet @Over-Thinker

Subrata2003 commented 2 years ago

Now check please

nikhil25803 commented 2 years ago

Hey @Over-Thinker , also define the endpoint in the main.py file. Set the endpoints as agriculture_colleges

nikhil25803 commented 2 years ago

There are some merge conflicts, please resolve them first.