[FLOC-4552] Harden EBS tag parsing

ClusterHQ / flocker

Container data volume manager for your Dockerized application

https://clusterhq.com

Apache License 2.0

3.38k stars 288 forks source link

[FLOC-4552] Harden EBS tag parsing #2974

Closed wallrj closed 7 years ago

wallrj commented 7 years ago

Fixes: https://clusterhq.atlassian.net/browse/FLOC-4552

Based on https://github.com/ClusterHQ/flocker/pull/2973 with some extra logging and unit tests.

Thanks to @sgnn7 for reporting this issue and providing a patch.

wallrj commented 7 years ago

Well that went badly. Seems to be trying to contact th AWS API. On my laptop, the Volume s were created without any AWS API interaction. Perhaps there's some other way to create these resources.

wallrj commented 7 years ago

@sgnn7 Please review the changes in the branch and leave comments and / or a LGTM.