ClusterHQ / flocker

Container data volume manager for your Dockerized application
https://clusterhq.com
Apache License 2.0
3.39k stars 290 forks source link

[FLOC-4557] Bind mount /dev into the lsblk test container #2977

Closed wallrj closed 7 years ago

wallrj commented 7 years ago

Fixes:

Bind mount /dev into the lsblk test container so that multi-path devices can be examined.

@shay-berman please test this modified version of the acceptance test with your IBM driver.

I dug into the Docker and runc code to understand how /dev gets populated inside the container. See the comments and links in the patch.

shay-berman commented 7 years ago

I just planned to push that fix to the project(for my first flocker contribution) but you did that first :-)

wallrj commented 7 years ago

@shay-berman great minds think alike :-)

Let me know how your testing goes.

The tests still seem to pass on with the Loopback driver on Centos7, Ubuntu 16.04 and Ubuntu 14.04

wallrj commented 7 years ago

See https://github.com/docker/docker/issues/16160 for more discussion of why /dev inside the container does not have all the devices that are available on the host server.