search

ClusterHQ / unofficial-flocker-tools

A tool to make installing Flocker with container orchestration tools easier and more fun
https://clusterhq.com/
11 stars 9 forks source link

Compose install instructions are out of date [was: Compose install instructions don't work if you've installed Flocker] #23

Open lukemarsden opened 9 years ago

lukemarsden commented 9 years ago

Following the instructions here: https://docs.clusterhq.com/en/1.0.1/labs/compose.html

We are told to run:

$ sudo pip install git+https://github.com/lukemarsden/compose.git@volume_driver

However, because Flocker is already installed on these nodes, and because docker-py is a dep of flocker, docker-py is already installed too. And so, perhaps due to version number incongruity, the custom version of docker-py does not get pulled down (I think).

Manually running:

$ sudo pip install --upgrade git+https://github.com/lukemarsden/docker-py.git@e2ba8a54935df8d40676529f67b16f5927e51000#egg=docker-py
$ sudo pip install 'requests>=2.6.1,<2.7'

Resolves this issue.

lukemarsden commented 9 years ago

@binocarlos I saw this in manual testing, would you mind testing to confirm the issue exists?

WDYT about fixing this? We could just wait for a compose release that includes volume_driver support, although maybe adding a note to the docs in the meantime would help.

Or maybe we could declare a tighter dependency in https://github.com/lukemarsden/compose/tree/volume_driver somehow.

binocarlos commented 9 years ago

@lukemarsden Can confirm that this issue exists having tested it manually - once I had done the manual pip install step it did not complain about missing 'volume-driver' any more.

I'm not sure how we can specify a tighter dependency than a git commit hash?

I will put a note in the labs docs about these extra 2 steps I think that is the best plan until the change is merged into master.

lukemarsden commented 8 years ago

we should update the compose docs to refer to the fact that mainline compose supports volume_driver now.