Review: Swarm integration

ClusterHQ / unofficial-flocker-tools

A tool to make installing Flocker with container orchestration tools easier and more fun

https://clusterhq.com/

11 stars 9 forks source link

Review: Swarm integration #49

Closed wallnerryan closed 8 years ago

wallnerryan commented 8 years ago

Looking to review this, few things

This integrates installing Swarm with the --swarm flag to uft-flocker-config script
The integration only works with swarm and ubuntu
The integration used default ports 2375 for swarm agents and 2357 for swarm master. Should this be configurable? What about TLS?
This restarts the docker daemon within a UFT cluster to listen on unix socket and external port, should we edit the docker.service file (managed by systemd) instead?
needs to be tested with one test.

lukemarsden commented 8 years ago

Generally this looks great, thanks for working on this! I've left a few review comments which should be addressed before we merge this. I'd be glad to pair fixup-and-merge this changeset with you.

lukemarsden commented 8 years ago

I'm going to merge this now because having some (even undocumented) support for swarm in UFT is better than nothing. But I'd still really like the review comments to be addressed in a follow-up PR. @wallnerryan can you make sure that's on your (not insignificant, I'm sure) todo list please? :grinning:

wallnerryan commented 8 years ago

will take a look at addressing these changes soon. Will also update https://github.com/ClusterHQ/unofficial-flocker-tools/issues/48 when it gets completed.