Closed wallnerryan closed 8 years ago
Generally this looks great, thanks for working on this! I've left a few review comments which should be addressed before we merge this. I'd be glad to pair fixup-and-merge this changeset with you.
I'm going to merge this now because having some (even undocumented) support for swarm in UFT is better than nothing. But I'd still really like the review comments to be addressed in a follow-up PR. @wallnerryan can you make sure that's on your (not insignificant, I'm sure) todo list please? :grinning:
will take a look at addressing these changes soon. Will also update https://github.com/ClusterHQ/unofficial-flocker-tools/issues/48 when it gets completed.
Looking to review this, few things
--swarm
flag touft-flocker-config
script2375
for swarm agents and2357
for swarm master. Should this be configurable? What about TLS?docker.service
file (managed by systemd) instead?