[FLOC-4538] Remove bash specific syntax from the installer and the installed script.

[wallrj]

Fixes: https://clusterhq.atlassian.net/browse/FLOC-4538 Refs: https://github.com/ClusterHQ/unofficial-flocker-tools/issues/73

On Fedora

$ ls -l /usr/bin/sh
lrwxrwxrwx 1 root root 4 Sep 30 09:25 /usr/bin/sh -> bash

But on Ubuntu 16.04:

$ ls -l /bin/sh
lrwxrwxrwx 1 root root 4 Feb 17  2016 /bin/sh -> dash

read -d is used in the installer and the installed script, but it's bash specific.

I caused this bug in https://github.com/ClusterHQ/unofficial-flocker-tools/pull/72/files 🙁

[wallrj]

Here's how it looks when installed and run on Ubuntu 16.04.

richard@richardw-pet-ubuntu1604:/$ curl -sSL https://raw.githubusercontent.com/ClusterHQ/unofficial-flocker-tools/fix-illegal-read-arg-FLOC-4538/go.sh |sh
Installed /usr/local/bin/flockerctl
Installed /usr/local/bin/uft-flocker-ca (deprecated)
Installed /usr/local/bin/uft-flocker-deploy (deprecated)
Installed /usr/local/bin/uft-flocker-config (deprecated)
Installed /usr/local/bin/uft-flocker-install (deprecated)
Installed /usr/local/bin/uft-flocker-plugin-install (deprecated)
Installed /usr/local/bin/uft-flocker-sample-files (deprecated)
Installed /usr/local/bin/uft-flocker-tutorial (deprecated)
Installed /usr/local/bin/uft-flocker-volumes (deprecated)
Installed /usr/local/bin/uft-flocker-get-nodes (deprecated)
Installed /usr/local/bin/uft-flocker-destroy-nodes (deprecated)
Installed /usr/local/bin/volume-hub-agents-install
Verifying internet connectivity inside container...
Pulling Docker image for Flocker installer...
latest: Pulling from clusterhq/uft
8387d9ff0016: Already exists 
3b52deaaf0ed: Already exists 
4bd501fad6de: Already exists 
a3ed95caeb02: Already exists 
b2417fb4bf25: Already exists 
2b599980924e: Already exists 
4c9fcc4f5358: Already exists 
Digest: sha256:683e7d46bd05da0f868d42fda1c0925a31afd83914e576d03e4ec1dabdc3eb27
Status: Image is up to date for clusterhq/uft:latest

WARNING: Some of these commands were deprecated in Flocker 1.14.0 and will be removed in future versions of Flocker.
Use the official installation methods and tools instead.
See https://docs.clusterhq.com.

richard@richardw-pet-ubuntu1604:/$ uft-flocker-deploy 
WARNING: uft-flocker-deploy was deprecated in Flocker 1.14.0 and will be removed in future versions of Flocker.
Use the official installation methods and tools instead.
See https://docs.clusterhq.com.

Usage: flocker-deploy [OPTIONS] <control-host> <deployment.yml-path> <application.yml-path>

If you have any issues or feedback, you can talk to us: https://docs.clusterhq.com/en/latest/gettinginvolved/contributing.html#talk-to-us
Options:
  -p, --port=                    The REST API port on the server. [default:
                                 4523]
      --cacert=                  Path to cluster certificate file.
      --cert=                    Path to user certificate file.
      --key=                     Path to user private key file.
  -c, --certificates-directory=  Path to directory containing TLS certificates
                                 and keys. Defaults to current directory.
      --help                     Display this help and exit.
      --journald                 Log to journald.
      --version                  Print the program's version and exit.
      --logfile=                 Log to a file. Log is written to ``stdout`` by
                                 default. The logfile directory is created if it
                                 does not already exist.
  -v, --verbose                  Turn on verbose logging.

flocker-deploy allows you to configure existing nodes.
ERROR: Wrong number of arguments.

[wallrj]

@vchernoy I've responded to your comments (above) but let me know when you've finished reviewing this branch and if you approve it, remember to move the Jira issue to the approved column: https://clusterhq.atlassian.net/browse/FLOC-4538

[wallrj]

@vchernoy I'll assume that you're happy with this and merge it.