ClusterLabs / OCF-spec

http://standards.clusterlabs.org
20 stars 11 forks source link

Release the OCF RA API 1.1 standard #24

Closed kgaillot closed 3 years ago

kgaillot commented 3 years ago

The main goals of this revision are to formalize existing widespread practice that deviates from or extends the 1.0 standard, and to add optional new meta-data hints that user interfaces can benefit from.

A summary of changes from the 1.0 standard:

nrwahl2 commented 3 years ago

Love it. I especially like the improved definitions of exit status codes and OCF_CHECK_LEVEL values, and I think unique-group is a major improvement over unique.

kgaillot commented 3 years ago

@tomjelinek @oalbrigt @liangxin1300 @MalloZup @ioguix : My goal is to merge this in a couple of weeks. Please look this over to consider how it might affect your projects, and whether any final changes are needed.

kgaillot commented 3 years ago

I have updated this PR with four new commits:

which are carried over to 1.1 via the updated "bring in proposed changes" commit.

@nrwahl2 @ioguix and anyone else interested, please review and let me know what you think. I hope to merge this at the end of this week or early next week.

nrwahl2 commented 3 years ago

@kgaillot Capitalization skips "Parameter passing" and "Global OCF attributes". Not sure if intentional.

Everything looks good to me otherwise.

I felt a little bit iffy about "reload-agent", since the agent is sort of getting reloaded on every recurring monitor as-is -- but I can't think of any alternative that's clearer. I get that there may be certain actions that the agent only takes during start or reload-agent. So I think this is fine and we can rely on the description for clarification.

kgaillot commented 3 years ago

@kgaillot Capitalization skips "Parameter passing" and "Global OCF attributes". Not sure if intentional.

Whoops, not intentional. Fixed.

kgaillot commented 3 years ago

Last chance for comments, I'll merge tomorrow