search

ClusterLabs / cluster-glue

Reusable Cluster Components ("glue")
http://clusterlabs.org/
GNU General Public License v2.0
18 stars 28 forks source link

Import debian patches #27

Closed lge closed 3 years ago

lge commented 3 years ago

I went through the debian/patches/series file (actually taken from Ubuntu launchpad), and I think we should just take them.

So I massaged them just slightly (no trailing white space and similar), and added "guessed" attribution where it was missing.

@dmuhamedagic (Hi there! We should have some :beers: again some time!), maybe you find time to look them over as well, just in case? @wferi,@vvidic just so you know, you may have something to add, or thoughts or request?

Not exactly sure about the python shebang, we currently have two /usr/bin/env python and one /usr/bin/python. Should we fix that as well to one or the other? Or python3 (because, now with 2e09b707e4761943d64108ebe1dc6492e305b676 apparently they are)?

dmuhamedagic commented 3 years ago

I went through the debian/patches/series file (actually taken from Ubuntu launchpad), and I think we should just take them.

So I massaged them just slightly (no trailing white space and similar), and added "guessed" attribution where it was missing.

Thanks! I wasn't aware of these at all.

@dmuhamedagic (Hi there! We should have some beers again some time!), maybe you find time to look them over as well, just in case?

I took a look and all seems to be fine.

Not exactly sure about the python shebang, we currently have two /usr/bin/env python and one /usr/bin/python. Should we fix that as well to one or the other? Or python3 (because, now with 2e09b70 apparently they are)?

As they seem to be python3 once this is committed, I guess that it should be #!/usr/bin/env python3.

dmuhamedagic commented 3 years ago

@lge beers of course as soon as cafes open :)