search

ClusterLabs / cluster-glue

Reusable Cluster Components ("glue")
http://clusterlabs.org/
GNU General Public License v2.0
18 stars 28 forks source link

bugfix for comment in external/ec2 #36

Closed thimslugga closed 2 years ago

thimslugga commented 2 years ago

fix for comment where colon was used instead of pound

gguifelixamz commented 2 years ago

LGTM

beninidavide commented 2 years ago

I understand the change is adding a comment where before was used the colon. The : is to be considered as true, so basically, it was doing an instruction But apart from this, I see no changes in execution; am I missing anything?

I can see that changing the : to a comment enforces a check in the block executed: if the line following the comment is commented, having at the above line a : would give no syntax error (as : is an instruction) , while having a comment would make the then block empty and would give warnings