ClusterLabs / crmsh

Command-line interface for High-Availability cluster management on GNU/Linux systems.
GNU General Public License v2.0
131 stars 94 forks source link

Give a warning when detecting $SSH_AUTH_SOCK but not using `--use-ssh-agent` option #1363

Closed liangxin1300 closed 6 months ago

liangxin1300 commented 6 months ago
15sp5-2:~ # ssh-add -L
ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQC23EY1HDEpErQZaLNSV3PMylHm5z/WO45B+ekFoEwAsq7NIWSQBf7Az17FfvltsF9jgsnaABdhe2mnLaLWnvpIkwuX/NEBUpTEURr1Ij0iwAWddPV2bxwwRGGS8anc+Sky7RoBfedN/lWwbsjr+0Sj41x2QJ1UPHVaeb+WSfDzlJSeQsCiySsSumwAc6Vt5uUrwIYew1pi46jmEdE5dSqRxaxxHbA7f1eZYgRKcTXP9ISDDK4v8jZJuecEnjpOCDHigRDDP1ctZRlzl/4CMglVr1YVHG9EdmxltnVjd23uJMtbrKOW+FscoCwRC2w6xe+PdEd3sZ2CKipIca8AoXqOLOXh53sSlI+SV6E30H/PI9N7c8QWprVbSbRtheNY+4yFPsmUgcqXbA1K7GU+9ML7kEkoUGsAXjceX2HrH7D6gIncHnmkR0L472DfOV2fCW1SEOLfYXZMoRTzhjJqhH8rbDNOdNGoj9br6Pn97edmyzDoF2e8sUD0Tmwdfa0ffNU= root@15sp5-3
15sp5-2:~ # echo $SSH_AUTH_SOCK
/tmp/ssh-soZVZdH2f1/agent.8390
15sp5-2:~ # crm cluster join -c 15sp5-1 -y
WARNING: chronyd.service is not configured to start at system boot.
INFO: A new ssh keypair is generated for user root.
INFO: A new ssh keypair is generated for user hacluster.

This node login with ssh-agent, but does not use(mostly forget) --use-ssh-agent option

On this time, crmsh should give a warning like

"WARNING: $SSH_AUTH_SOCK is detected. As a tip, using the --use-ssh-agent option could avoid generate local root ssh keys on cluster nodes." 
liangxin1300 commented 6 months ago

PR in #1366