search

ClusterLabs / crmsh

Command-line interface for High-Availability cluster management on GNU/Linux systems.
GNU General Public License v2.0
131 stars 94 forks source link

Multiple " target-role=Stopped" #720

Closed liangxin1300 closed 1 year ago

liangxin1300 commented 3 years ago

When resource has multiple meta entries, multiple target-role=Stopped will be added while stopping the resource:

primitive d Dummy \
        meta priority=123 target-role=Stopped \
        meta resource-stickiness=0 allow-migrate=true target-role=Stopped \
        op monitor interval=10s

@zzhou1 @gao-yan Do you think this is a bug?

zzhou1 commented 3 years ago

From the conceptual level, I do read it as a cusmetic issue. I found another cusmetic one as below very recently. No sure if the root cause is same, at least it is similiar.

sle15sp2-2:~ # crm config show p_fs
primitive p_fs Filesystem \
        op monitor interval=30s \
        op_params OCF_CHECK_LEVEL=20 \
        params device="/dev/vg1/lv1" directory="/srv/nfs" fstype=xfs
sle15sp2-2:~ # crm resource trace p_fs
INFO: Trace for p_fs is written to /var/lib/heartbeat/trace_ra/
INFO: Trace set, restart p_fs to trace non-monitor operations
sle15sp2-2:~ # crm config show p_fs
primitive p_fs Filesystem \
        op start interval=0 \
        op_params trace_ra=1 \
        op stop interval=0 \
        op_params trace_ra=1 \
        op monitor interval=30s \
        op_params OCF_CHECK_LEVEL=20 trace_ra=1 \
        params device="/dev/vg1/lv1" directory="/srv/nfs" fstype=xfs
sle15sp2-2:~ # crm resource untrace p_fs
sle15sp2-2:~ # crm config show p_fs
primitive p_fs Filesystem \
        op monitor interval=30s \
        op_params OCF_CHECK_LEVEL=20 \
        params device="/dev/vg1/lv1" directory="/srv/nfs" fstype=xfs
liangxin1300 commented 2 years ago

From the conceptual level, I do read it as a cusmetic issue. I found another cusmetic one as below very recently. No sure if the root cause is same, at least it is similiar.

sle15sp2-2:~ # crm config show p_fs
primitive p_fs Filesystem \
        op monitor interval=30s \
        op_params OCF_CHECK_LEVEL=20 \
        params device="/dev/vg1/lv1" directory="/srv/nfs" fstype=xfs
sle15sp2-2:~ # crm resource trace p_fs
INFO: Trace for p_fs is written to /var/lib/heartbeat/trace_ra/
INFO: Trace set, restart p_fs to trace non-monitor operations
sle15sp2-2:~ # crm config show p_fs
primitive p_fs Filesystem \
        op start interval=0 \
        op_params trace_ra=1 \
        op stop interval=0 \
        op_params trace_ra=1 \
        op monitor interval=30s \
        op_params OCF_CHECK_LEVEL=20 trace_ra=1 \
        params device="/dev/vg1/lv1" directory="/srv/nfs" fstype=xfs
sle15sp2-2:~ # crm resource untrace p_fs
sle15sp2-2:~ # crm config show p_fs
primitive p_fs Filesystem \
        op monitor interval=30s \
        op_params OCF_CHECK_LEVEL=20 \
        params device="/dev/vg1/lv1" directory="/srv/nfs" fstype=xfs

This is the expected behavior by design, please see crm resource help trace

liangxin1300 commented 1 year ago

See discussion in https://github.com/ClusterLabs/crmsh/pull/1008#discussion_r1039410607