search

ClusterLabs / fence-agents

Fence agents
104 stars 160 forks source link

fence_vbox: do not flood host account (history) with vboxmanage calls #379

Closed BlackZork closed 3 years ago

BlackZork commented 3 years ago

This change disables bash history when checking vm status on host. Useful mainly in devel installations, where fence_vbox.py fills user .bash_history with:

VBoxManage list vms VBoxManage list runningvms

I think that there is no reason to log those commands in production environment, hence this pull request.

Tested on Centos7.8 and Virtualbox 6.1.16

knet-ci-bot commented 3 years ago

Can one of the admins verify this patch?

oalbrigt commented 3 years ago

Can you prefix the commit with "fence_vbox: " ? You can do it by running git commit --amend followed by git push -f.

oalbrigt commented 3 years ago

You have to run make xml-upload and add the updated metadata to avoid CI failing.

oalbrigt commented 3 years ago

ok to test

oalbrigt commented 3 years ago

LGTM. Thanks.