search

ClusterLabs / fence-agents

Fence agents
104 stars 160 forks source link

fence_azure_arm: corrections to support Azure SDK >= 15 #410

Closed cleberps closed 3 years ago

cleberps commented 3 years ago

We have found that fence_azure_arm do not work after Azure SDK >= 15. We initiated this PR to report the problem and part of the solutions because there are other points that need attention. Below are them: 1) Back support to older versions of Azure SDK < 15. Code must be improved to detect the version that is running and select functions accordingly. 2) Other functions from agent were not tested yet, but could suffer from same changes in SDK. Contributions and comments are welcome.

knet-ci-bot commented 3 years ago

Can one of the admins verify this patch?

diegoakechi commented 3 years ago

@cleberps thanks for initiating this. About backward compatibility, I believe this section of the documentation points some directions on how to do it

https://docs.microsoft.com/en-us/azure/developer/python/azure-sdk-authenticate#credential-object-has-no-attribute-signed_session

oalbrigt commented 3 years ago

Closing in favour of reference issue w/backwards compatibility.