search

ClusterLabs / fence-agents

Fence agents
104 stars 160 forks source link

fence_gce: Add timeouts and failure options #458

Closed kj1724 closed 2 years ago

kj1724 commented 2 years ago

This allows the agent to be more flexible to the users needs and improves reliability.

knet-ci-bot commented 2 years ago

Can one of the admins verify this patch?

oalbrigt commented 2 years ago

ok to test

oalbrigt commented 2 years ago

Can you run make xml-upload and add the updated metadata to the PR?

kj1724 commented 2 years ago

I tried to run make xml-upload and for most of the directories it says Nothing to be done for 'xml-upload'. However in the agents directory it outputs a bunch of logs which looks like it should be doing something. After it is finished running none of the files change. Do I need to do anything else?

I updated the metadata file for fence_gce.

oalbrigt commented 2 years ago

I tried to run make xml-upload and for most of the directories it says Nothing to be done for 'xml-upload'. However in the agents directory it outputs a bunch of logs which looks like it should be doing something. After it is finished running none of the files change. Do I need to do anything else?

I updated the metadata file for fence_gce.

You probably havent installed the googleapiclient and/or oauth2client libs: https://github.com/ClusterLabs/fence-agents/blob/64d2ef3fdac7bd4f86ebccb11282ce97d3bddbe3/configure.ac#L287-L294

oalbrigt commented 2 years ago

Thanks.