search

ClusterLabs / fence-agents

Fence agents
104 stars 160 forks source link

depends on deprecated oauth2client, replace with google-auth and google-auth-oauthlib #495

Closed mcepl closed 2 years ago

mcepl commented 2 years ago

It is in agents/gce/fence_gce.py

oauth2client deprecation: https://google-auth.readthedocs.io/en/latest/oauth2client-deprecation.html

oalbrigt commented 2 years ago

It uses google-auth and falls back to oauth2client if google-auth isnt available (to avoid breaking the agent in older distro versions where google-auth isnt available): https://github.com/ClusterLabs/fence-agents/blob/main/agents/gce/fence_gce.py#L37-L40

I've updated the configure check, so it checks for google-auth now, as that only shows whether you got the expected libraries or not: https://github.com/ClusterLabs/fence-agents/pull/496

mcepl commented 2 years ago

Thank you, that's good to know. That means this is no problem for me anymore.