ClusterLabs / fence-agents

Fence agents
104 stars 160 forks source link

fence_eaton_ssh: new fence agent for Eaton ePDU G3 over SSH #549

Closed SchoolGuy closed 1 year ago

SchoolGuy commented 1 year ago

Since the Eaton SNMP fence is not feasible for the infrastructure I am responsible for, I have decided to implement this fence that will use the Eaton SSH/Serial interface.

I also took the liberty to reformat the README to 120 characters so it is easier readable when looked at in raw and to improve the Python typing experience so adding new fences is easier.

knet-jenkins[bot] commented 1 year ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/1/input

knet-jenkins[bot] commented 1 year ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/2/input

knet-jenkins[bot] commented 1 year ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/3/input

knet-jenkins[bot] commented 1 year ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/4/input

SchoolGuy commented 1 year ago

Missing points:

All other functionality is tested as described in the docstrings. An initial feeling from someone about the code would be helpful as I am getting close to completing this PR.

knet-jenkins[bot] commented 1 year ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/5/input

knet-jenkins[bot] commented 1 year ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/6/input

SchoolGuy commented 1 year ago

This PR is now ready for review. The new fence is tested as described in the Python docstring.

knet-jenkins[bot] commented 1 year ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/7/input

oalbrigt commented 1 year ago

Looks good. Can you run make xml-upload and add it to the PR, so CI doesnt fail?

SchoolGuy commented 1 year ago

@oalbrigt Done. Thanks for the quick review!

knet-jenkins[bot] commented 1 year ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/8/input

knet-jenkins[bot] commented 1 year ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/9/input

oalbrigt commented 1 year ago

Thanks.