Closed SchoolGuy closed 1 year ago
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/1/input
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/2/input
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/3/input
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/4/input
Missing points:
nodename
instead of the plug number.set_power_status
must be tested manually.reboot_cycle
must be implemented and tested.sync_set_power
must be implemented and tested.fence_agent -o metadata
All other functionality is tested as described in the docstrings. An initial feeling from someone about the code would be helpful as I am getting close to completing this PR.
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/5/input
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/6/input
This PR is now ready for review. The new fence is tested as described in the Python docstring.
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/7/input
Looks good. Can you run make xml-upload
and add it to the PR, so CI doesnt fail?
@oalbrigt Done. Thanks for the quick review!
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/8/input
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents-pipeline/job/PR-549/9/input
Thanks.
Since the Eaton SNMP fence is not feasible for the infrastructure I am responsible for, I have decided to implement this fence that will use the Eaton SSH/Serial interface.
I also took the liberty to reformat the README to 120 characters so it is easier readable when looked at in raw and to improve the Python typing experience so adding new fences is easier.