fencing: Add Error Message & Use EC_OK

[razo7]

- Four error codes (EC_INVALID_PRIVILEGES, EC_STATUS_HMC, EC_FETCH_VM_UUID, and EC_BAD_ARGS) have not been used, thus they can be dismissed.

• Add error message for EC_GENERIC_ERROR
• Use EC_OK and return result (equals to EC_OK).

[knet-jenkins[bot]]

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents/job/fence-agents-pipeline/job/PR-554/1/input

[knet-jenkins[bot]]

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents/job/fence-agents-pipeline/job/PR-554/2/input

[knet-jenkins[bot]]

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents/job/fence-agents-pipeline/job/PR-554/3/input

[oalbrigt]

We want to keep those. They could be used by external agents, and also we dont want to change the return code numbers as pcs and other utilities map their values to know what has happened.

[oalbrigt]

The EC_OK/result parts look good though. Makes the code easier to read IMO.

[razo7]

I understand. What about the Add error message for EC_GENERIC_ERROR commit? Should it stay with EC_OK/result commit?

[oalbrigt]

Yeah. That looks good to me. I dont think it was intended for that, but shouldnt hurt.

[knet-jenkins[bot]]

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents/job/fence-agents-pipeline/job/PR-554/4/input

[knet-jenkins[bot]]

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents/job/fence-agents-pipeline/job/PR-554/5/input

[knet-jenkins[bot]]

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents/job/fence-agents-pipeline/job/PR-554/6/input

[oalbrigt]

Thanks.