git placeholders are not expanded in release tarballs

[ryandesign]

git placeholders are not expanded in the libqb-2.0.8.tar.xz and libqb-2.0.8.tar.gz release tarballs, suggesting that they were not created by git archive.

For example, if I use the automatically-generated v2.0.8.tar.gz tarball that I know from #312 I'm not supposed to use, this line:

https://github.com/ClusterLabs/libqb/blob/40542f314ebe7312fa995677ed5c967150dd5d6a/configure.ac#L9

is expanded to:

    m4_esyscmd([build-aux/git-version-gen $(echo '002171bbc??tag: v2.0.8'\

and this line:

https://github.com/ClusterLabs/libqb/blob/40542f314ebe7312fa995677ed5c967150dd5d6a/configure.ac#L816

is expanded to:

         SOURCE_EPOCH='1689939039' # template for rewriting by git-archive

However in the release tarballs these $Format:…$ placeholders remain unchanged.

[chrissie-c]

Hi, thanks for this.

The code does actually work, there's a check for 'Format:' in a case statement later in configure and the SOURCE_EPOCH is being updated through that. Whether this is the intent I'm not 100% sure as that code is copied from kronosnet and I didn't originate it. I'll consult with Fabio when he returns from holiday next week.

In the meantime I don't think it's a problem though.

[jfriesse]

release.mk is using distcheck makefile target, not git archive. So it is expected git placeholders remain untouched. Same behavior is across libqb/knet/corosync/corosync-qdevice so if we decide to fix it we should fix it in all projects. The question is if this is really problem or not, because git placeholders are used to overcome problems with git archive generated archives (mostly version number) and such problems are not present in officially released tarballs created by release.mk.