ClusterLabs / resource-agents

Combined repository of OCF agents from the RHCS and Linux-HA projects
GNU General Public License v2.0
493 stars 579 forks source link

Mid: ocf-shellfuncs: Explicitly specify $OCF_RESOURCE_INSTANCE in the p parameter for compatibility. #1848

Closed HideoYamauchi closed 1 year ago

HideoYamauchi commented 1 year ago

Hi All,

The following fixes were made in pacemaker:

For compatibility, specify the option specification explicitly.

Best Regards, Hideo Yamauchi.

oalbrigt commented 1 year ago

I dont think this makes sense. It's up to the agent to specify $OCF_RESOURCE_INSTANCE.

oalbrigt commented 1 year ago

I'll ask Ken about it just to be sure I'm not missing the point here.

HideoYamauchi commented 1 year ago

Hi Oyvind,

Okay!


If you don't have $OCF_RESOURCE_INSTANCE after the p option, you will have problems with some combinations of pacemaker and resource-agent versions.

Or are you saying it's better to specify the p option last?

${HA_SBIN_DIR}/crm_attribute $@ -p

Best Regards, Hideo Yamauchi

HideoYamauchi commented 1 year ago

I'll ask Ken about it just to be sure I'm not missing the point here.

All right!

Thanks! Hideo Yamauchi.

oalbrigt commented 1 year ago

Thanks. Ken confirmed this solves the issue for 2.1.0-2.1.5.

HideoYamauchi commented 1 year ago

Thanks. Ken confirmed this solves the issue for 2.1.0-2.1.5.

OKay!

Many thanks, Hideo Yamauchi.