search

ClusterLabs / resource-agents

Combined repository of OCF agents from the RHCS and Linux-HA projects
GNU General Public License v2.0
489 stars 577 forks source link

Mid: storage-mon: daemonize storage_mon to deal with I/O hangs.(Add daemon/client mode) #1862

Closed HideoYamauchi closed 1 year ago

HideoYamauchi commented 1 year ago

Hi All, Hi @wenningerk Hi @oalbrigt

I was late in proposing a fix. This fix is a modified version of the following PR.

Connect the storage-mon client from RA to the storage-mon daemon and execute attrd_updater on the RA side. IPC communication of libqb is used between daemon and client.

Please comment on this fix.

Best Regards, Hideo Yamauchi.

wenningerk commented 1 year ago

Give me a bit for a full review but basically I guess I like the approach.

HideoYamauchi commented 1 year ago

Hi @wenningerk

Give me a bit for a full review but basically I guess I like the approach.

Okay! I will wait for your review to be completed.

Many thanks, Hideo Yamauchi.

wenningerk commented 1 year ago

Okay! I will wait for your review to be completed.

Many thanks, Hideo Yamauchi.

Small unplanned surgery got in the way - so I didn't manage to play with it except basic config yet ...

HideoYamauchi commented 1 year ago

Okay! I will wait for your review to be completed. Many thanks, Hideo Yamauchi.

Small unplanned surgery got in the way - so I didn't manage to play with it except basic config yet ...

Okay! We are not in a hurry yet.

Is this about LIBQB_CFLAGS? If so, I will take action as soon as possible.

Best Regards, Hideo Yamauchi.

wenningerk commented 1 year ago

Okay! I will wait for your review to be completed. Many thanks, Hideo Yamauchi.

Small unplanned surgery got in the way - so I didn't manage to play with it except basic config yet ...

Okay! We are not in a hurry yet.

Is this about LIBQB_CFLAGS? If so, I will take action as soon as possible.

LIBQB_CFLAGS probably won't be an issue for testing. with surgery I meant me being in hospital with limited testing possibilities.

Klaus

Best Regards, Hideo Yamauchi.

HideoYamauchi commented 1 year ago

Okay! I will wait for your review to be completed. Many thanks, Hideo Yamauchi.

Small unplanned surgery got in the way - so I didn't manage to play with it except basic config yet ...

Okay! We are not in a hurry yet. Is this about LIBQB_CFLAGS? If so, I will take action as soon as possible.

LIBQB_CFLAGS probably won't be an issue for testing. with surgery I meant me being in hospital with limited testing possibilities.

All right. Please take care.

Hideo Yamauchi.

oalbrigt commented 1 year ago

Can you run git rebase upstream/main and git push -f? That would clear out the CI errors, as they have already been fixed.

HideoYamauchi commented 1 year ago

Can you run git rebase upstream/main and git push -f? That would clear out the CI errors, as they have already been fixed.

Sorrry...

I may have made a mistake. In the final PR, I think that the CI error will disappear because I will fix it based on the synchronized main again.

knet-jenkins[bot] commented 1 year ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents-pipeline/job/PR-1862/1/input

HideoYamauchi commented 1 year ago

Hi All,

In the next week or so, I plan to issue a PR again, including the points pointed out so far.

Best Regards, Hideo Yamauchi.