search

ClusterLabs / resource-agents

Combined repository of OCF agents from the RHCS and Linux-HA projects
GNU General Public License v2.0
489 stars 577 forks source link

Mid: storage-mon: daemonize storage_mon to deal with I/O hangs.(Add daemon/client mode) #1886

Closed HideoYamauchi closed 10 months ago

HideoYamauchi commented 1 year ago

Hi All,

This fix is a modified version of the following PR.

This PR reflects the comments in the previous PR.

Please comment on this fix.

Best Regards, Hideo Yamauchi.

knet-jenkins[bot] commented 1 year ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-1886/1/input

wenningerk commented 11 months ago

add BuildRequires: libqb-devel and Requires: libqb to the spec-file.

Isn't the BuildRequires-Part already in the patch? And shouldn't the Requires-Part be automatically generated?

oalbrigt commented 11 months ago

add BuildRequires: libqb-devel and Requires: libqb to the spec-file.

Isn't the BuildRequires-Part already in the patch? And shouldn't the Requires-Part be automatically generated?

Ah. I see. I was trying to build on one of the distros, and forgot to diff the spec :)

The Requires part isnt auto generated though. But will probably be present be present in most cases due to Pacemaker or deps depending on it. So adding it is only to ensure it's working if anyone is installing it without those.

oalbrigt commented 11 months ago

add BuildRequires: libqb-devel and Requires: libqb to the spec-file.

Isn't the BuildRequires-Part already in the patch? And shouldn't the Requires-Part be automatically generated?

Ah. I see. I was trying to build on one of the distros, and forgot to diff the spec :)

The Requires part isnt auto generated though. But will probably be present be present in most cases due to Pacemaker or deps depending on it. So adding it is only to ensure it's working if anyone is installing it without those.

Correction. The Requires is auto-generated as well, so ignore the spec-part of my review :)

HideoYamauchi commented 11 months ago

Hi Oyvind,

Check and correct the comments for OCF_RESKEY_daemonize_default and OCF_RESKEY_daemonize.

Many thanks, Hideo Yamauchi.

oalbrigt commented 11 months ago

@HideoYamauchi They are correct. We should use ocf_is_true

Hi Oyvind,

Check and correct the comments for OCF_RESKEY_daemonize_default and OCF_RESKEY_daemonize.

Many thanks, Hideo Yamauchi.

Done.

oalbrigt commented 10 months ago

Thanks.

HideoYamauchi commented 10 months ago

Hi Oyvind,

Thanks for merging this fix.

Best Regards, Hideo Yamauchi.