ClusterLabs / resource-agents

Combined repository of OCF agents from the RHCS and Linux-HA projects
GNU General Public License v2.0
489 stars 577 forks source link

Update nfsnotify.in #1906

Closed LaluprasadJaladi closed 7 months ago

LaluprasadJaladi commented 7 months ago

The shabang line is wrong so it is failing to notify nfs resource in pacemaker cluster.

knet-jenkins[bot] commented 7 months ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-1906/1/input

fabbione commented 7 months ago

This patch is incorrect and unnecessary. the shebang is replaced when configuring and building resource-agents and it will create nfsnotify file that should be used.

fabbione commented 7 months ago

resource-agents]$ ./autogen.sh [SNIP]

resource-agents]$ ./configure [SNIP]

resource-agents]$ make all -j [SNIP]

resource-agents]$ diff -Nuard heartbeat/nfsnotify.in heartbeat/nfsnotify --- heartbeat/nfsnotify.in 2021-12-01 06:13:55.989376328 +0100 +++ heartbeat/nfsnotify 2023-12-21 12:06:50.949364691 +0100 @@ -1,4 +1,4 @@ -#!@BASH_SHELL@ +#!/usr/bin/bash #

Copyright (c) 2014 David Vossel davidvossel@gmail.com

All Rights Reserved.