search

ClusterLabs / resource-agents

Combined repository of OCF agents from the RHCS and Linux-HA projects
GNU General Public License v2.0
488 stars 577 forks source link

LVM-activate: Avoid false positive for VG activation #1909

Closed arslan9292 closed 5 months ago

arslan9292 commented 5 months ago

When lvm.conf file has volume_list parameter configured and the cluster is managing the shared storage using system_id_source, then the activation of the LV fails to happen. However it is reported as a success.

The fixes will avoid starting of LVM-activate resource when the cluster is configured with both system_id_source and volume_list.

knet-jenkins[bot] commented 5 months ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-1909/1/input

teigland commented 5 months ago

In LVM, volume_list has no relationship with system_id, and in it's perfectly fine to use them both together. So, it's possible that this change could break a legitimate setup. Could this patch check for specific values in volume_list that would indicate it's been mistakenly configured for tagging with LVM-activate?

teigland commented 5 months ago

After more info I think this is a good solution.