986ebe18 (nfsserver: Fix NFSv4 lock failover: set NFS Server Scope (#1688), 2021-10-13)
Prefixes all ExecStart=.* with an unshare --uts. It did not expect an existing "empty, resetting" ExecStart=, though, and changed that as well. The attempt to fix that with
806e3fe9 (nfsserver: fix "server scope" functionality to live with additional drop-in files, 2023-02-15)
it wrong though: it only fixes the last ExecStart found (|tail -1). There may be more than one ExecStart (even though arguable some of them should be ExecStartPost).
Without the "only last line", it would be a valid fix, though it would unnecessarily list irrelevant ExecStart lines as well.
My attempt to fix the fix:
Find the set of ExecStart=... lines after the last reset (ExecStart=), if any. Edit in the "unshare uts" prefix into all of those lines.
(we could also patch only the line containing rpc.nfsd, but I'm sure some distro will find creative ways to break our assumptions again)
oalbrigt
commented
3 months ago
986ebe18 (nfsserver: Fix NFSv4 lock failover: set NFS Server Scope (#1688), 2021-10-13)
Prefixes all
ExecStart=.*with an unshare --uts. It did not expect an existing "empty, resetting"ExecStart=, though, and changed that as well. The attempt to fix that with806e3fe9 (nfsserver: fix "server scope" functionality to live with additional drop-in files, 2023-02-15)
it wrong though: it only fixes the last ExecStart found (
|tail -1). There may be more than one ExecStart (even though arguable some of them should be ExecStartPost).Without the "only last line", it would be a valid fix, though it would unnecessarily list irrelevant ExecStart lines as well.
My attempt to fix the fix: Find the set of
ExecStart=...lines after the last reset (ExecStart=), if any. Edit in the "unshare uts" prefix into all of those lines.(we could also patch only the line containing rpc.nfsd, but I'm sure some distro will find creative ways to break our assumptions again)