ClusterLabs / resource-agents

Combined repository of OCF agents from the RHCS and Linux-HA projects
GNU General Public License v2.0
488 stars 577 forks source link

`ocf_local_nodename` incorrectly detect pacemaker version causing incorrect behavior #1942

Open Sildulir opened 1 month ago

Sildulir commented 1 month ago

Since https://github.com/ClusterLabs/pacemaker/commit/67e342d78f1c0972dd14d8a3f731b06bc8208747 pacemakerd -$ return two lines containing matching the regex used by ocf_local_nodename to detect the version of pacemaker used.

This break version detection and cause ocf_local_nodename to use uname -n instead of crm_node -n to get the name of the local node. Breaking any agent relying on this function on a node that doesn't use its hostname as its nodename.

I noticed this problem when attempting to use ganesha_grace from the GlusterFS project, but this function seems to be used by agents in this repository too (and using this function should be the correct thing to do anyway).

oalbrigt commented 1 month ago

Thanks. I'll look into it.