ClusterLabs / resource-agents

Combined repository of OCF agents from the RHCS and Linux-HA projects
GNU General Public License v2.0
493 stars 581 forks source link

powervs-subnet: new resource agent #1948

Closed ehaefele closed 3 months ago

ehaefele commented 3 months ago

This new resource agent adds functionality to manage subnets and IP addresses for virtual servers running in IBM Power Virtual Server.

modified:   doc/man/Makefile.am
modified:   heartbeat/Makefile.am
new file:   heartbeat/powervs-subnet.in
knet-jenkins[bot] commented 3 months ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-1948/1/input

knet-jenkins[bot] commented 3 months ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-1948/2/input

oalbrigt commented 3 months ago

You forgot to update the indentation in the Makefile's.

knet-jenkins[bot] commented 3 months ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-1948/3/input

knet-jenkins[bot] commented 3 months ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-1948/5/input

oalbrigt commented 3 months ago

Can you add heartbeat/powervs-subnet to .gitignore as well?

knet-jenkins[bot] commented 3 months ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-1948/6/input

knet-jenkins[bot] commented 3 months ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-1948/7/input

oalbrigt commented 3 months ago

CI fails on different distros (Debian testing and RHEL8), so seems like some of the string-formatting features are added to Python too recently.

We currently target Python 3.6+ for resource-agents.

knet-jenkins[bot] commented 3 months ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-1948/8/input

knet-jenkins[bot] commented 3 months ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-1948/9/input

knet-jenkins[bot] commented 3 months ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-1948/10/input

knet-jenkins[bot] commented 3 months ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-1948/11/input

knet-jenkins[bot] commented 3 months ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-1948/12/input

knet-jenkins[bot] commented 3 months ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-1948/13/input

oalbrigt commented 3 months ago

Great. That solved it.

You introduced some whitespace on a couple of lines in the last commit, so I'll let you clean out those so we get as clean a start as possible.

knet-jenkins[bot] commented 3 months ago

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-1948/14/input

ehaefele commented 3 months ago

O.K., I've removed the whitespaces - so ready to merge ...

oalbrigt commented 3 months ago

Thanks.