ClusterM / retroarch-clover

GNU General Public License v3.0
321 stars 50 forks source link

Latest Retroarch does not show scanlines on NES #152

Open rhester72 opened 6 years ago

rhester72 commented 6 years ago

There's a single missing line in /bin/retroarch-clover-child:

--- retroarch-clover-child.orig 2017-11-10 15:19:19.486291500 -0500
+++ retroarch-clover-child      2017-11-10 15:15:28.630514800 -0500
@@ -22,6 +22,7 @@
   [ "$1" == "--save-screenshot-on-quit" ] && screenshot=$2
   [ "$1" == "--save-data-backing-file" ] && sram=$2
   [ "$1" == "--graphic-filter" ] && filter=$2
+  [ "$1" == "--enable-crt-scanlines" ] && crt=1
   [ "$1" == "--video-mode" ] && [ "$2" == "crt-filter" ] && filter=crt720 && crt=1
   [ "$1" == "--video-mode" ] && [ "$2" == "keep-aspect-ratio" ] && filter=gpu720
   [ "$1" == "--video-mode" ] && [ "$2" == "pixel-perfect" ] && filter=ppu

I deliberately did not add support for --ra-allow-crt since a) it's only supported on /bin/nes, which means Snes9x would break and b) use of overlays versus shaders should not cause much of a performance hit.