add .off() to remove event handler

ClusterWS / ClusterWS-Client-JS

:fire: JavaScript Client for ClusterWS - lightweight, fast and powerful framework for building scalable WebSocket applications in Node.js.

MIT License

115 stars 10 forks source link

add .off() to remove event handler #52

Closed ramjak closed 5 years ago

ramjak commented 5 years ago

Submitting

[ ] Bug fix
[x] Feature
[ ] Other

Details

add .off() to remove event handler

goriunov commented 5 years ago

@ramjak Thanks for PR, would you be able to making the same for Server ClusterWS it has similar event emitter, would be good to replace removeEvent with off ?

ramjak commented 5 years ago

Is this one good enough, https://github.com/ClusterWS/ClusterWS/pull/128? I don't quite understand the server part. When this going to be released?

goriunov commented 5 years ago

@ramjak I will try to release this client version by next week (have to sort out some other issues not related to ClusterWS). The server part can be a bit confusing but it is not very complicated overall if you understand the order things happening :)