search

Clybius / ComfyUI-Latent-Modifiers

A repository of ComfyUI nodes which modify the latent during the diffusion process.
GNU General Public License v3.0
75 stars 9 forks source link

Some changes to comfyui cause `Latent-Modifiers` to work very poorly #2

Closed mijuku233 closed 11 months ago

mijuku233 commented 1 year ago

Some recent changes to comfyui have caused the effect of using the Latent-Modifier to be poorly

This custom node is great, it became an integral part of my workflow, please fix it!

Clybius commented 1 year ago

Thanks for reporting this issue!

I believe it's due to commit 1777b54

I'll take a look into this immediately. In the meantime, could you send me your node settings for the image shown so I can attempt to replicate this locally?

EDIT: It appears quite a few functions are broken, I'll see what I can do

mijuku233 commented 1 year ago

@Clybius This update https://github.com/comfyanonymous/ComfyUI/commit/d2e27b48f169b0e5def6b9b2c7874e4010282921 fixes the effect of sharpness, but there is still a problem with contrast!

Clybius commented 1 year ago

Thanks for the update on it!

I can't seem to replicate the old contrast function exactly after the recent commits, even after tuning around a bit.

I will still push a commit within the next 24 hours or so for an update. It'll have a fix for contrast (should be in a good usable state after that), as well as some new functions.

Clybius commented 1 year ago

Pushed the changes, feel free to let me know on if there's further issues (I expect there to be some small bugs leftover, but most important functions are somewhat fixed)

mijuku233 commented 11 months ago

The problem is basically solved now, fantastic, thanks again!