Upon building the project, I encountered static assertion failures related to block size mismatches in the temporal filtering tests. Here are the pertinent error messages:
... in member function ‘void {anonymous}::TemporalFilterTest::RunTest(...):
error: static assertion failed: static_assert(block_size == BLOCK_32X32, "");
... in member function ‘void {anonymous}::HBDTemporalFilterTest::RunTest(...):
error: static assertion failed: static_assert(block_size == BLOCK_32X32, "");
These static assertions are no longer valid due to the changes, resulting in compilation failures. An update to the test files to align with the amended block size definition seems necessary.
I suggest the test code be updated to reflect the change in TF_BLOCK_SIZE or, if this was an unintended change in the header file, that TF_BLOCK_SIZE be reverted to BLOCK_32X32.
Could we get a fix for this issue to avoid the build errors?
https://github.com/Clybius/aom-av1-lavish/blob/3b4594d81bed823c41ad95a195cd4b321aebdd07/test/temporal_filter_test.cc#L134
Upon building the project, I encountered static assertion failures related to block size mismatches in the temporal filtering tests. Here are the pertinent error messages: ... in member function ‘void {anonymous}::TemporalFilterTest::RunTest(...): error: static assertion failed: static_assert(block_size == BLOCK_32X32, "");
... in member function ‘void {anonymous}::HBDTemporalFilterTest::RunTest(...): error: static assertion failed: static_assert(block_size == BLOCK_32X32, "");
It appears that the test cases are expecting a block size defined as
BLOCK_32X32, while the constant intemporal_filter.hhas recently been updated toBLOCK_16X16. https://github.com/Clybius/aom-av1-lavish/blob/3b4594d81bed823c41ad95a195cd4b321aebdd07/av1/encoder/temporal_filter.h#L31These static assertions are no longer valid due to the changes, resulting in compilation failures. An update to the test files to align with the amended block size definition seems necessary.
I suggest the test code be updated to reflect the change in
TF_BLOCK_SIZEor, if this was an unintended change in the header file, thatTF_BLOCK_SIZEbe reverted toBLOCK_32X32.Could we get a fix for this issue to avoid the build errors?