search

CmdrDats / clj-minecraft

Clojure Bukkit plugin, Minecraft.
74 stars 35 forks source link

Update to bukkit 1.6.4, etc? #43

Closed rogerallen closed 11 years ago

rogerallen commented 11 years ago

Bukkit has updated to 1.6.4 and this project is still at 1.4.5. In addition, most of the other libraries are a bit stale, too. My first attempt at updating fails & I see a couple forks ( @DavidJRobertson, @ddeaguiar ) have also updated project dependencies.

I'm curious if we could all try to work together to bring this main project up-to-date?

DavidJRobertson commented 11 years ago

I abandoned my attempts to update/use this and instead went for writing my plugin in ruby using this: https://github.com/enebo/Purugin

ddeaguiar commented 11 years ago

I updated the project dependencies and had it working with clojure 1.5.1 and bukkit 1.5.2. I haven't messed with it in a while but I'm open to dedicating time to the effort. I had also updated the clj-minecraft template project and created a lein plugin for deployment.

rogerallen commented 11 years ago

Thanks for the feedback, @DavidJRobertson & @ddeaguiar. To bring it up to date, the full list is kind of long:

org.clojure/clojure         "1.4.0"      -> "1.5.1"
org.clojure/tools.logging   "0.2.3"      -> "0.2.6"
org.clojure/tools.nrepl     "0.2.0-RC1"  -> "0.2.3"
org.bukkit/bukkit           "1.4.5-R1.0" -> "1.6.4-R1.0"
clojure-complete            "0.2.2"      -> "0.2.3"
cheshire                    "2.0.4"      -> "5.2.0"
org.reflections/reflections "0.9.8"      -> "0.9.9-RC1"

@ddeaguiar do you think you have a pull-request for some of this? I think I might try to update the easier-looking projects, just to see if they are no effort. Your changes for bukkit 1.5.2 might be useful for the effort to get to 1.6.4...

p.s. thanks for the pointers to the lein projects, too!

rogerallen commented 11 years ago

Using some of @ddeaguiar's code as a base, I have a branch that touches on many of these here https://github.com/rogerallen/clj-minecraft/tree/deps1 I could do a pull-request if that would be useful.

These still remain to be updated and since reflections is just a RC, it seems like something we can just forgo for now.

org.bukkit/bukkit           "1.4.5-R1.0" -> "1.6.4-R1.0"
cheshire                    "2.0.4"      -> "5.2.0"
org.reflections/reflections "0.9.8"      -> "0.9.9-RC1"
CmdrDats commented 11 years ago

Hey guys, thanks for the effort & time spent on this, really appreciate it! @rogerallen, @ddeaguiar - I could open an upgrade dev branch that we could work on so that we can do the upgrades in many smaller PR's? Alternatively, I'm not entirely averse to having a broken master branch while we work on the upgrade :)

rogerallen commented 11 years ago

I left changing the bukkit release out to keep things simple over the weekend. But, if I just update the version to "1.6.4-R2.0" (released Oct 30), I don't see any immediate issues.

@CmdrData, do you want to just update that? Are there any tests to run?

CmdrDats commented 11 years ago

@rogerallen Cool - update it to 1.6.4-R2.0 - there are no tests to run, but we can just fix any issues that crop up.

rogerallen commented 11 years ago

Okay, see pull request #45

After that, it seems this bug can be closed.

CmdrDats commented 11 years ago

Great, thanks a mil! Pulled and closed.