CnCNet / ts-patches

Command and Conquer: Tiberian Sun patches for CnCNet online gameplay.
GNU General Public License v3.0
42 stars 15 forks source link

Bug: `SpeechSide=` no longer works #108

Closed Bittah closed 5 months ago

Bittah commented 5 months ago

SpeechSide= under [Basic] in mission maps no longer works and this specifically appears to be caused by certain code that's present in all mod specific hack files ( ts_hacks.asm, dta_hacks.asm, ti_hacks.asm, to_hacks.asm, rubicon_hacks.asm, fd_hacks.asm, tm_hacks.asm):

; Load speech MIX files for new sides properly
@SET 0x005DD822, {xor ecx, ecx}
@CLEAR 0x005DD824, 0x90, 0x005DD828
@SET 0x005DD82B, {mov cl, byte [0x007E2500]} ; Compile warning: byte value exceeds bounds?
Bittah commented 5 months ago

Fixed by 28bd831.