CnCNet / xna-cncnet-client

XNA / MonoGame based client for playing classic Command & Conquer games both online and offline with a CnCNet game spawner.

Other

228 stars 91 forks source link

Make optimal and preferred resolutions configurable #307

Closed SadPencil closed 2 years ago

SadPencil commented 2 years ago

Modders may want a bigger screen size but magic values like 1280x800 are hard-coded. This PR makes these hard-coded resolutions configurable. It also fixes an incorrect implementation of GetHashCode().

Rampastring commented 2 years ago

275 already does this for recommended resolutions.

github-actions[bot] commented 2 years ago

Nightly build for this pull request:

artifacts.zip This comment is automatic and is meant to allow guests to get latest automatic builds without registering. It is updated on every successful build.

SadPencil commented 2 years ago

275 already does this for recommended resolutions.

Oops. Well, please apply the following change to that PR to fix the incorrect implementation. DisplayOptionsPanel.cs

            public override int GetHashCode()
            {
                return new { Width, Height }.GetHashCode();
                // return Width - Height;
            }