CnCNet / xna-cncnet-client

XNA / MonoGame based client for playing classic Command & Conquer games both online and offline with a CnCNet game spawner.
Other
228 stars 91 forks source link

Allow option to sort map list #311

Closed devo1929 closed 2 years ago

devo1929 commented 2 years ago

This removes the default sorting of maps alphabetically and instead adds a sort button to the left of the game mode drop down list.

The list is not sorted by default. The setting for the sort selection is stored in user ini settings.

image

github-actions[bot] commented 2 years ago

Nightly build for this pull request:

devo1929 commented 2 years ago

@Metadorius Updated code to be more map general in naming conventions. The action is actually sorting the specific class of GameModeMap. So, my naming convention followed suit. Although, at a higher level, you're actually sorting the map list. So, I renamed everything per your suggestion. Either way doesn't matter to me. Whatever is more clear.

Rampastring commented 2 years ago

I suggest using the full word "alphabetically" instead of shortening it, maybe btnSortMapsAlphabetically. "Alpha" often refers to opacity in alpha blending (which is heavily utilized on the graphical side of the client) so the current name seems confusing at first glance.

devo1929 commented 2 years ago

I suggest using the full word "alphabetically" instead of shortening it, maybe btnSortMapsAlphabetically. "Alpha" often refers to opacity in alpha blending (which is heavily utilized on the graphical side of the client) so the current name seems confusing at first glance.

Updated

Metadorius commented 2 years ago

Let's wait for TSCv6 to be merged then merge this.

Metadorius commented 2 years ago

@Rampastring @devo1929 could you update this branch? We'll merge it afterwards.