Post v6 updates - Githubissues

CnCNet / xna-cncnet-client

XNA / MonoGame based client for playing classic Command & Conquer games both online and offline with a CnCNet game spawner.

Other

228 stars 91 forks source link

Post v6 updates #315

Closed devo1929 closed 2 years ago

devo1929 commented 2 years ago

Improve ini config file locating
- This slightly improves the backwards compatibility of the new INItializableWindow implementation.
- With the initial INItializableWindow updates, there seemed to be no inheritance of which ini config file to load for a given class implementing INItializableWindow. If it has an override ini name, it would attempt to use it, but not fall back to the name of the control itself, which could be the parent class' name.
Make BasedOn a list for multi inheritance
Fix missing toggle fav map event
Add starting documentation for INI system
Fix bug in XNAClientButton

github-actions[bot] commented 2 years ago

Nightly build for this pull request:

artifacts.zip This comment is automatic and is meant to allow guests to get latest automatic builds without registering. It is updated on every successful build.

Metadorius commented 2 years ago

Added a fix for extra player options, still can't see it by default but it doesn't crash at least.

upd: removed the fix

devo1929 commented 2 years ago

I haven't tested it, but the code changes look good.

I'm on the fence about multiple inheritance being a good idea as I'm expecting modders to be able to create confusing situations for themselves with it. But I guess we should rather provide them the power than prevent them from shooting themselves in the foot.

In the end, I ended up not using it. So, if you want me to revert it, I'm ok with that. It won't hurt to leave it in though as it's entirely optional to use.