#327 Map search across all maps

CnCNet / xna-cncnet-client

XNA / MonoGame based client for playing classic Command & Conquer games both online and offline with a CnCNet game spawner.

Other

228 stars 91 forks source link

#327 Map search across all maps #328

Open devo1929 opened 2 years ago

devo1929 commented 2 years ago

github-actions[bot] commented 2 years ago

Nightly build for this pull request:

artifacts.zip This comment is automatic and is meant to allow guests to get latest automatic builds without registering. It is updated on every successful build.

alexp8 commented 2 years ago

Why are you adding this functionality? Searching for maps within the current game mode is preferred imo

@devo1929

devo1929 commented 2 years ago

Why are you adding this functionality? Searching for maps within the current game mode is preferred imo

@devo1929

It removes the limitation that you must know the game mode a map is in to find it. If I can't remember the game mode, I can still search for it across all maps and it'll find it and show me the game mode.

What's the reason for preferring it to stay within the game mode?

alexp8 commented 2 years ago

In the screenshot you showed there it is very confusing, a player searching for the official Mayflower map is now presented with 5 other options. Not great

alexp8 commented 2 years ago

If anything add a toggle to enable that. By default it should search within the current game mode

devo1929 commented 2 years ago

In the screenshot you showed there it is very confusing, a player searching for the official Mayflower map is now presented with 5 other options. Not great

IMO, the names "Battle" and "Standard" are confusing. To me, they don't mean "Official" and "Custom" which is what they truly are and "Standard" seems more "Official" than "Battle" does.

If I were in the "Stardard" game mode and searched for Mayflower. I would see a map with the exact same name as the official one. At least this way, it shows there's a difference.

alexp8 commented 2 years ago

If those names are confusing to you, your solution here actually exacerbates that confusion providing maps from both game modes.

alexp8 commented 2 years ago

My opinion is that this should not be merged without some sort of toggle on/off. I know for me this feature would annoy me lol.

devo1929 commented 2 years ago

My opinion is that this should not be merged without some sort of toggle on/off. I know for me this feature would annoy me lol.

Fair enough. That's why I create the PRs, to create the conversation :)

Rampastring commented 2 years ago

You could consider renaming Standard to Custom Map in YR by changing the game mode's UI name, or by using game mode aliases.

Metadorius commented 2 years ago

I agree with @alexp8, this should be a toggleable functionality. Perhaps you could do it as a settings option.