CnCNet / xna-cncnet-client

XNA / MonoGame based client for playing classic Command & Conquer games both online and offline with a CnCNet game spawner.
Other
226 stars 87 forks source link

Fixed .editorconfig and added validation to workflows #372

Open Belonit opened 1 year ago

Belonit commented 1 year ago

We use this workflow at Phobos and it works well

Rans4ckeR commented 1 year ago

FYI we are planning to merge below PR before all others, which will generate quite some conflicts I'm afraid.

Metadorius commented 1 year ago

I think it would be beneficial if you reset your branch to pre-fix and then reapply all warning fixes.

Belonit commented 1 year ago

@Metadorius Yes, I'll do it a little later

Belonit commented 1 year ago

I updated this PR and consider it is done

github-actions[bot] commented 1 year ago

Nightly build for this pull request:

Belonit commented 1 year ago

The council ™️ concluded that the style checks should absolutely NOT fail a workflow. Instead look into making a problem matcher and registering it so that it displays issues as inline annotations (same applies for Phobos one as it's quite annoying to get failed runs just because of a stray trailing space): https://github.com/actions/toolkit/blob/main/docs/problem-matchers.md

Currently, GitHub Actions limit the annotation count in a workflow run.

If your workflow may exceed these annotation counts, consider filtering of the log messages which the Problem Matcher is exposed to (e.g. by PR touched files, lines, or other).

Metadorius commented 1 year ago

I think those counts are reasonable and we can work with that. Not sure why you closed the PR though?

Belonit commented 1 year ago

I think those counts are reasonable and we can work with that. Not sure why you closed the PR though?

I'm not sure why it closed either. Possibly missclick