search

CnCNet / xna-cncnet-client

XNA / MonoGame based client for playing classic Command & Conquer games both online and offline with a CnCNet game spawner.
Other
224 stars 85 forks source link

RA2/YR Intro Movie Crash Fix #425

Open ayylmaoRotE opened 1 year ago

ayylmaoRotE commented 1 year ago

Adds the [Intro] and Play=no section to RA2MD.ini to prevent an error that occurs only when a fresh copy of the client goes on a game install that has yet to play the intro movie, causing the game to never open

Rampastring commented 4 months ago

Optimally this should be fixed in the spawners.

Metadorius commented 4 months ago

Optimally this should be fixed in the spawners.

I think it would still be beneficial to have this fix even if it should be fixed on the spawner side. Imagine a situation where the spawner is not updated but the client is, and the mod author just doesn't know about the issue. We could prevent more issues with fixes on both sides in place.

Rampastring commented 4 months ago

I'd agree if there was something preventing us from updating the spawners, but we have full control over all existing YR spawners.

We can just notify mod authors to update their spawner.

If we start fixing spawner bugs in the client, we could eventually have a massive number of spawner bug fixes on the client side, making the client code bloated and more difficult to maintain than necessary.

Metadorius commented 4 months ago

I don't think there's a whole ton of spawner bugs though?

@Belonit do you have this issue fixed already in your spawner reimpl?

Belonit commented 4 months ago

I don't think there's a whole ton of spawner bugs though?

@Belonit do you have this issue fixed already in your spawner reimpl?

Yes. yrpp-spawner does not play intro moves

SadPencil commented 4 months ago

I don't think there's a whole ton of spawner bugs though? @Belonit do you have this issue fixed already in your spawner reimpl?

Yes. yrpp-spawner does not play intro moves

i.e., this issue will not exist on the latest spawner, right? If so we could just close this issue with a "won't fix"

Belonit commented 4 months ago

I don't think there's a whole ton of spawner bugs though? @Belonit do you have this issue fixed already in your spawner reimpl?

Yes. yrpp-spawner does not play intro moves

i.e., this issue will not exist on the latest spawner, right? If so we could just close this issue with a "won't fix"

Yes, that's right. But this only applies to yrpp-spawner, I don’t know what happens in other games with a other spawner