Make gitversion conditionally included with .git folder

CnCNet / xna-cncnet-client

XNA / MonoGame based client for playing classic Command & Conquer games both online and offline with a CnCNet game spawner.

Other

228 stars 89 forks source link

Make gitversion conditionally included with .git folder #436

Closed devo1929 closed 1 year ago

github-actions[bot] commented 1 year ago

Nightly build for this pull request:

artifacts-Ares.zip
artifacts-TS.zip
artifacts-YR.zip This comment is automatic and is meant to allow guests to get latest automatic builds without registering. It is updated on every successful build.

SadPencil commented 1 year ago

I prefer tell developers always get codes via git clone

devo1929 commented 1 year ago

I would prefer removing the NuGet package and adding the necessary steps in the workflow.

The NuGet package is what automatically embeds the version in the assembly.

devo1929 commented 1 year ago

I prefer tell developers always get codes via git clone

I tend to agree. Maybe instead of making the package conditional on the existence of a .git folder, it throws a warning or even error message when the .git folder doesn't exist when attempting to build, a message that is more descriptive than just "gitversion.json not found" which a developer might not understand. We could simply say "you must clone the repo to build" or something better.