Suppress code style warnings and use central package management

CnCNet / xna-cncnet-client

XNA / MonoGame based client for playing classic Command & Conquer games both online and offline with a CnCNet game spawner.

Other

223 stars 86 forks source link

Suppress code style warnings and use central package management #513

Closed frg2089 closed 4 months ago

frg2089 commented 4 months ago

Close #512 48046a6b0794a337829ccba25093eb256708431c Close #501 4e8a9a18c80aa55d2e3ab02389ae04fd29297a1b

github-actions[bot] commented 4 months ago

Nightly build for this pull request:

artifacts-TS.zip
artifacts-Ares.zip
artifacts-YR.zip This comment is automatic and is meant to allow guests to get latest automatic builds without registering. It is updated on every successful build.

frg2089 commented 4 months ago

Should I fixed #515 in this PR?

SadPencil commented 4 months ago

Should I fixed #515 in this PR?

I think not unless your want your PR being reviewed for months

MahBoiDeveloper commented 4 months ago

Warning NU1903 seems to be critical one.

frg2089 commented 4 months ago

Warning NU1903 seems to be critical one.

We cannot fix it now. Because the ImageSharp 3 are not supported .Net Framework. We must have another solution to replace ImageSharp. such as SkiaSharp. It should be resolved in another PR.

[!note] SkiaSharp only supported .jpg, .png and .webp formats.

SadPencil commented 4 months ago

Warning NU1903 seems to be critical one.

~~Just ignore it. The client only loads pictures from local files instead of Internet so it is pretty fine to ignore this high risk.~~

Obsolete. See messages below

SadPencil commented 4 months ago

Warning NU1903 seems to be critical one.

We cannot fix it now. Because the ImageSharp 3 are not supported .Net Framework. We must have another solution to replace ImageSharp. such as SkiaSharp. It should be resolved in another PR.

Note

SkiaSharp only supported .jpg, .png and .webp formats.

https://github.com/SixLabors/ImageSharp/releases/v2.1.7

They released v2.1.7 to backport for .NET Framework an hour ago. Upgrading to this version should be fine

Metadorius commented 4 months ago

Warning NU1903 seems to be critical one.

Just ignore it. The client only loads pictures from local files instead of Internet so it is pretty fine to ignore this high risk.

The upcoming MapDB 2.0 may change that status quo, so I am not sure if it's fine. We must also account possible future features too.

SadPencil commented 4 months ago

Warning NU1903 seems to be critical one.

Just ignore it. The client only loads pictures from local files instead of Internet so it is pretty fine to ignore this high risk.

The upcoming MapDB 2.0 may change that status quo, so I am not sure if it's fine. We must also account possible future features too.

That message is obsolete since v2.1.7 is released

Metadorius commented 4 months ago

The upcoming MapDB 2.0 may change that status quo, so I am not sure if it's fine. We must also account possible future features too.

That message is obsolete since v2.1.7 is released

That's fine, I just wanted to highlight the importance of foreseeing the future changes in general.

Metadorius commented 4 months ago

Let's merge this after the ImageSharp upgrade that fixes the issue.