Fix current selected map is not preserved during game mode changes

CnCNet / xna-cncnet-client

XNA / MonoGame based client for playing classic Command & Conquer games both online and offline with a CnCNet game spawner.

Other

228 stars 89 forks source link

Fix current selected map is not preserved during game mode changes #549

Closed SadPencil closed 3 months ago

SadPencil commented 3 months ago

Currently, previous map is only preserved if both game mode and map are identical before and after changes. So it won't work as people usually expected.

This PR corrects this behavior so that as long as there exists a GameModeMap whose map is identical before and after changes, regardless of the game mode, it would be selected. Note: if a GameModeMap matches both game mode and the map (i.e., switching to/from favorite map), it would have the top priority.

github-actions[bot] commented 3 months ago

Nightly build for this pull request:

artifacts-TS.zip
artifacts-YR.zip
artifacts-Ares.zip This comment is automatic and is meant to allow guests to get latest automatic builds without registering. It is updated on every successful build.

SadPencil commented 3 months ago

https://github.com/CnCNet/xna-cncnet-client/blame/56638037c79c8b2f611aac6c32223d042e123ede/DXMainClient/DXGUI/Multiplayer/GameLobby/GameLobbyBase.cs#L625