Allow cloaked units under player control to have SELECT cursor on it when about to select

[chaserli]

Basically at this point it's useless to do all these checks. What had the program done?

if(!this->IsArmed() || !this->Owner->ControlledByCurrentPlayer() || this->Owner==pObject->GetOwningHouse())
    if((this->Spawned || !this->ControlledByCurrentPlayer)
          && pObject->CanBeSelected() &&..)
         return Action::Select;

 return Action::None;

This is the very end of that function it's not sufficient to only let "me" select pObject if it belongs to this->Owner which is known to be controlled by me. It is also possible that "I" (the controller of this) can only control the owning house of pObject but is not it. In that case you gotta let me select it too

[github-actions[bot]]

Nightly build for this pull request:

• compiled-dll-regular-adcd7bc92cc7e82e19ab28500bb7f2249507188b.zip
• compiled-dll-hardend-adcd7bc92cc7e82e19ab28500bb7f2249507188b.zip These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[Belonit]

@chaserli If you don't mind, I'll get back to this PR in a couple of weeks. There are a few other things I'm busy with right now

[chaserli]

@chaserli If you don't mind, I'll get back to this PR in a couple of weeks. There are a few other things I'm busy with right now

sure not, you could even work on #21 before this one