CntoDev / OCAP

OCAP is a game-changing tool that allows the recording and playback of operations on an interactive (web-based) map.
Other
0 stars 0 forks source link

Zeus (`Curator`) Units are visible in the OCAP replay #1

Open lastmikoi opened 7 years ago

lastmikoi commented 7 years ago

As of now (2017-02-15), every event AAR hosted in CNTO's OCAP instance are displaying the Zeus/Curator/GM units as regular units.

This might be misleading since the general workflow for Curators is to set themselves invisible and teleport right in the middle of the action.

Ideally we would want to hide or completely remove tracking of Curators by OCAP, while still tracking AI units controlled by them.

isakic commented 7 years ago

I'll run some tests after work today, I think I can fix this. This is what i would add to the capture loop:

_entityIsCurator = _entity in allCurators;

and then check against it before pushing data into the array.

However, it might be more beneficial to add a "curator" flag next to the entity/player declaration so that the curator can be filtered out by the client during playback.

What would you prefer?

Abuk007 commented 7 years ago

Toggleable approach would be better with defaults to not visible.

16 lut 2017 09:04 "Ivan Šakić" notifications@github.com napisał(a):

I'll run some tests after work today, I think I can fix this. This is what i would add to the capture loop:

_entityIsCurator = _entity in allCurators;

and then check against it before pushing data into the array.

However, it might be more beneficial to add a "curator" flag next to the entity/player declaration so that the curator can be filtered out by the client during playback.

What would you prefer?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CntoDev/OCAP/issues/1#issuecomment-280260313, or mute the thread https://github.com/notifications/unsubscribe-auth/AJDOXD9Brshm1uXsmIbyf4X3jPXhc9GKks5rdAMCgaJpZM4MCEKJ .

lastmikoi commented 7 years ago

I indeed think it makes more sense to do the filtering in the display side. Curator position is not a sensitive information and might even be useful in training new Curators by making them review OCAP replays with the toggle set to visible, since the default would be to hide it.

CptBananaPeel commented 7 years ago

i could possible see a solution where you loop through the entities in the webplayer, and then add visibility modifier for the group. I think, due to the current recording method, that it should be done in the webplayer, and not add a visibility check function in the recording.

lastmikoi commented 7 years ago

Tweaking https://github.com/CntoDev/OCAP/blob/master/web/scripts/ocap.js#L363 (which is the Unit-related marker update function) to add a handler to call setMarkerOpacity with 0 as an argument if the Unit is a Curator would be the best way to integrate such a system. In this case it would be done in the webplayer, and with a very similar behaviour to how units are being hidden when they enter a vehicle.

What is needed to make that work is a way of having a given Unit's Curator status in the original OCAP recording.

CptBananaPeel commented 7 years ago

was thinking, that a solution could be to loop through looking for the groupname "GM" which, I believe, is constant, and then implement your solution? and ofc, add a button beside the GM group to change visibility of them.

lastmikoi commented 7 years ago

Matching the group name seems like the best idea, and can be done directly in _updateAtFrame without even having to iterate (loop) over units since you can already access the current unit's group with this._group.

👍