CntoDev / django-roster

Web-based roster for tracking members and their attendance implemented in Django.
4 stars 3 forks source link

Django Promotion Notification error #75

Closed TRyujin closed 8 years ago

TRyujin commented 8 years ago

Dulabu and Goat yesterday received a notification from Django with following message:

Aug. 10, 2016, 9:35 a.m. Crystal has been demoted to Reservist due to attending less than 10.0 events between 2016-05-01 and 2016-06-30.

Aug. 8, 2016, 9:52 a.m. Hateborder has been promoted to Grunt due to attending at least 9.0 events between 2016-05-01 and 2016-06-30.

Aug. 10, 2016, 9:35 a.m. Hateborder has been demoted to Reservist due to attending less than 10.0 events between 2016-05-01 and 2016-06-30.

Two things are weird; Message was sent in middle of month, not at the end of two month period. Another thing weird is the criteria of 10 events, expected is 6 for May-June period.

supremefist commented 8 years ago

Could again be that the scraped events changed during the course of August (like last time) - for instance, someone scraped an event in July after August already started. The newly scraped event changes the required attendance.

The event count is strange, though. I'll check it out!

On Thu, Aug 11, 2016 at 12:22 PM, TRyujin notifications@github.com wrote:

Dulabu and Goat yesterday received a notification from Django with following message:

Aug. 10, 2016, 9:35 a.m. Crystal has been demoted to Reservist due to attending less than 10.0 events between 2016-05-01 and 2016-06-30.

Aug. 8, 2016, 9:52 a.m. Hateborder has been promoted to Grunt due to attending at least 9.0 events between 2016-05-01 and 2016-06-30.

Aug. 10, 2016, 9:35 a.m. Hateborder has been demoted to Reservist due to attending less than 10.0 events between 2016-05-01 and 2016-06-30.

Two things are weird; Message was sent in middle of month, not at the end of two month period. Another thing weird is the criteria of 10 events, expected is 6 for May-June period.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CntoDev/django-roster/issues/75, or mute the thread https://github.com/notifications/unsubscribe-auth/AB-VQIcBN96ze9qlSMCqoyedCR6uSMnCks5qevfKgaJpZM4Jh-2c .

supremefist commented 8 years ago

I have fixed a significant event filtering issue and recalculated the ranks. Events from July and August were being considered in the calculation (over 30 events), which is why the requirement was 10 events. The newly calculated ranks should be accurate!

Please accept my apology for this!

supremefist commented 8 years ago

This also explains the notifications from the middle of the month as new events were being scraped for the current cycle. This was incorrectly affecting the previous cycle.