search

CntoDev / django-roster

Web-based roster for tracking members and their attendance implemented in Django.
4 stars 3 forks source link

Fix CPL Rank Assignment #97

Open Gikerl opened 4 years ago

JamesTheClarke commented 4 years ago

Just saw this commit, sorry for the delay. What's the changelog / what is being added or changed through this commit? I'm not very fluent in Django. ;) I see that the rank CPL is added but how is it setup within the Roster? Or does it inherit the same rules as with SPCs?

enrico-ghidoni commented 3 years ago

Howdy. @Gikerl has the changelog already been submitted somewhere? If that's not the case, could you please describe (commenting here would be fine, opening a dedicated issue or linking an existing one would be great) what the purpose of the changes you made is?

Cheers :tada:

Gikerl commented 3 years ago

So the purpose of it was to fix this commit. The original implementation makes every SPC a CPL but we want to have both now.

So with these two commits, we want to add the CPL rank and once assign the SPCs (old ranking system) the new CPL rank.