Assigning ranks to members

[enrico-ghidoni]

Make all Ranks available (Recruit, Reservist, Grunt, Specialist, Corporal and Staff Sergeant) for promoting/demoting members.

Different ranks can be assigned by different people, thus the permission system should be updated accordingly.

I am not currently aware whether the community already has guidelines for which ranks/branch members can assign which ranks to other members (pinging @JamesTheClarke here to make sure). But ideally it should be something like this:

• only Interviewers and SSgts can promote a Recruit to the Reservist rank
• only Member Managers and SSgts can promote/demote Reservists, Grunts and Specialists to either three of those ranks (although a valid alternative would be to make only Branch managers be able to promote members to the Specialist rank, but that would require the Branch system to be in place so it can wait)
• only SSgts can promote members to Corporal and Staff Sergeant

[milivojm]

I'd rephrase this to:

• SSgts can promote Member to Corporal
• Branch Managers can promote Member to Specialists
• Members voting for SSgt promotion

Grunts, Reservists, Recruits will be managed automatically.

[enrico-ghidoni]

Moving discussion about automation to #68

[milivojm]

Maybe this is something we cannot do much about, it's a user command. It is linked with #60

[enrico-ghidoni]

For automation probably not. But the idea of the ranks system is heavily tied to permissions within the Roster, although the latter can be skipped for MVP in my opinion

[milivojm]

Yes, it's best to create a consumer in permissions service that listens to events like MemberPromoted and give appropriate permissions.

Right now we have no domain concept of Branch. We have Ranks which are tightly controlled by fixed values.

Work in progress.

[enrico-ghidoni]

Branches shouldn't be in the MVP I think. Although we'll have both Interviewers and Member Managers using new Roster so that could be an issue.

But then again, let's not fiddle with permissions right now and only handle the events for Rank promotion/demotion.

[milivojm]

Interviewing promotes from RCT to RES. SSGT promote SPC, CPL, SSGT.

System could automatically promote/demote RES/GNT based on attendance data.