search

CoBrALab / UKBB-tabular-processing

Scripts to handle the tabular data associated with the UK BioBank
8 stars 1 forks source link

add type annotations for config #4

Closed joshunrau closed 1 year ago

joshunrau commented 1 year ago

I added a Config class which defines the structure of the config object to be passed as argument to extract_UKBB_tabular_data. This does not change any runtime behavior, but makes it easier for developers to understand the codebase (and allows for static analysis with tools such as MyPy.

gdevenyi commented 1 year ago

Can you please run the code through black

gdevenyi commented 1 year ago

Changes are required to README if this change is made.

joshunrau commented 1 year ago

Can you please run the code through black d4ed15e5f68159436609590e4fb7f45acb38aa04

joshunrau commented 1 year ago

Changes are required to README if this change is made.

What kind of changes?

gdevenyi commented 1 year ago

Changes are required to README if this change is made.

What kind of changes?

The README describes the pythonic interface fairly generally, these changes improve that usage, worth describing how to use that.

joshunrau commented 1 year ago

Changes are required to README if this change is made.

What kind of changes?

The README describes the pythonic interface fairly generally, these changes improve that usage, worth describing how to use that.

14eb68e5078432eb0ae99c43329b0549ec35f1f2