Welford optimization - Githubissues

CoBrALab / optimized_antsMultivariateTemplateConstruction

A re-implementation of antsMultivariateTemplateConstruction2.sh using optimized image pyramid scale-space and qbatch support

Other

20 stars 8 forks source link

Welford optimization #90

Closed RyanHaniff closed 9 months ago

RyanHaniff commented 9 months ago

Changes made based on the feedback from the original PR https://github.com/CoBrALab/optimized_antsMultivariateTemplateConstruction/pull/88

gdevenyi commented 9 months ago

Looks good in terms of code.

Next up

compare /usr/bin/time -v of old and new code
write out the results as outputname.mnc and compare the mincstats outputname.mnc before and after this change

RyanHaniff commented 9 months ago

After doing some updates based on @gdevenyi suggestions, unbiased standard deviation is now being calculated.

Here are the results for runtime. Note that Welford method is calculating the mean and var/std at the same time. Compared to the previous way only mean or std or var was being calculated.

Runtime results: runtime_welford-mean-var_vs_mean

Mincstats results: welford-mean_vs_mean

gdevenyi commented 9 months ago

Great job!