search

CoBrALab / qbatch

The Unlicense
27 stars 13 forks source link

compute_threads with ppj > 1 and SGE breaks due to string #137

Closed gdevenyi closed 6 years ago

gdevenyi commented 7 years ago

Fails here https://github.com/pipitone/qbatch/blob/master/bin/qbatch#L483

Due to redefining ppj for SGE at: https://github.com/pipitone/qbatch/blob/master/bin/qbatch#L455

Easy solution is to use args.ppj at 483

dcoynel commented 7 years ago

Should this also be corrected at L515, in the other call of compute_threads ?

gdevenyi commented 7 years ago

It doesn't need to be, as ppj isn't rewritten in that code path.

gdevenyi commented 7 years ago

Oh shoot, I did totally miss a codepath, fix coming.

gdevenyi commented 7 years ago

Fixed now, please try again!