search

CoBrALab / qbatch

The Unlicense
27 stars 13 forks source link

setup.py needs to list dependencies properly #179

Closed pipitone closed 5 years ago

pipitone commented 5 years ago

It's currently possible to install qbatch with python2. Here is one way of enforcing python versions in setup.py.

Should also update the classifiers in setup.py to reflect this.

pipitone commented 5 years ago

My bad. Turns out qbatch does work with python 2.7 if the six package is installed, but this package isn't listed as a dependency in setup.py, it's in requirements.txt

Perhaps this ticket should be about clarifying the installation of qbatch, both by updating the README about which version of python is compatible, adding instructions on how to install from source (not just using pip), and making sure dependencies are install properly.

I'm not super current on python packaging these days, so perhaps it's just obvious to everyone using the source that requirements.txt stuff should be installed before running setup.py, in which case I could buy the argument we don't need to do anything. :-)

gdevenyi commented 5 years ago

Looks like I should have the requirements in both places..?

https://stackoverflow.com/questions/43658870/requirements-txt-vs-setup-py

gdevenyi commented 5 years ago

Fixed by #181